Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver
Date	2015-08-20 22:20 +0200
Message-ID	<pZEtA-6XY-9@gated-at.bofh.it> (permalink)
References	<pZt58-7r8-27@gated-at.bofh.it> <pZt58-7r8-25@gated-at.bofh.it> <pZuXg-1Hx-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote:
> On Thursday 20 August 2015 10:03:38, Marek Vasut wrote:
> > > +Example:
> > > +
> > > +			quadspi_controller_0: quadspi@0x180014a0 {
> > > +				compatible = "altr,quadspi-1.0";
> > > +				reg = <0x180014a0 0x00000020>,
> > > +				      <0x14000000 0x04000000>;
> > > +				reg-names = "avl_csr", "avl_mem";
> > > +				#address-cells = <1>;
> > > +				#size-cells = <0>;
> > > +				flash0: epcq256@0 {
> > > +					compatible = "altr,epcq256";
> > > +					#address-cells = <1>;
> > > +					#size-cells = <1>;
> > > +					partition@0 {
> > > +						/* 16 MB for raw data. */
> > > +						label = "EPCQ Flash 0 raw data";
> > > +						reg = <0x0 0x1000000>;
> > > +					};
> > > +					partition@1000000 {
> > > +						/* 16 MB for jffs2 data. */
> > > +						label = "EPCQ Flash 0 JFFS 2";
> > > +						reg = <0x1000000 0x1000000>;
> > > +					};
> > 
> > IIRC, encoding partitions into OF is deprecated (and it shouldn't be
> > part of the example anyway, so please remove this bit).
> 
> Do you mean specifying partitions in OF is deprecated in general? Is there any link for that?
> What would be an alternative to it?

This is the first I've heard of such a deprecation. I would argue that
it's still probably one of the best ways to specify partitions. It's not
exactly perfect (partitions aren't really "hardware", so may not belong
in the "hardware description"), but IMO it's better than cmdlineparts,
for instance. I also don't really know of any good-enough, generically
useful on-flash partition formats, especially ones that can handle the
complexities of NAND.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Marek Vasut <marex@denx.de> - 2015-08-20 10:10 +0200
  Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Viet Nga Dao <vndao@altera.com> - 2015-08-20 10:20 +0200
    Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Marek Vasut <marex@denx.de> - 2015-08-20 11:10 +0200
  Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Nga Chi <ngachi86@gmail.com> - 2015-08-20 10:20 +0200
    Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Marek Vasut <marex@denx.de> - 2015-08-20 11:10 +0200
      Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Viet Nga Dao <vndao@altera.com> - 2015-08-20 11:20 +0200
        Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Marek Vasut <marex@denx.de> - 2015-08-20 11:50 +0200
          Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Brian Norris <computersforpeace@gmail.com> - 2015-08-20 22:40 +0200
        Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Brian Norris <computersforpeace@gmail.com> - 2015-08-20 22:40 +0200
          Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Viet Nga Dao <vndao@altera.com> - 2015-08-21 03:40 +0200
  Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Alexander Stein <alexander.stein@systec-electronic.com> - 2015-08-20 12:10 +0200
    Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Brian Norris <computersforpeace@gmail.com> - 2015-08-20 22:20 +0200
      Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Marek Vasut <marex@denx.de> - 2015-08-21 00:10 +0200

csiph-web