Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210691

Re: [PATCH] mm/readahead.c: fix regression caused by small readahead limit

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm/readahead.c: fix regression caused by small readahead limit
Date 2015-08-20 21:30 +0200
Message-ID <pZDHc-5NN-5@gated-at.bofh.it> (permalink)
References <pZASZ-1Mh-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 20, 2015 at 9:19 AM, Roman Gushchin <klamm@yandex-team.ru> wrote:
> +       max_sane = max(MAX_READAHEAD,
> +                      (node_page_state(numa_node_id(), NR_INACTIVE_FILE) +
> +                       node_page_state(numa_node_id(), NR_FREE_PAGES)) / 2);

No, we're not re-introducing the idiotic and broken per-node logic.
There was a reason it was killed.

There have been other patches suggested that actually use _valid_
heuristics, this is not one of them.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm/readahead.c: fix regression caused by small readahead limit Roman Gushchin <klamm@yandex-team.ru> - 2015-08-20 18:30 +0200
  Re: [PATCH] mm/readahead.c: fix regression caused by small readahead limit Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-20 21:30 +0200
    [PATCH] mm: use only per-device readahead limit Roman Gushchin <klamm@yandex-team.ru> - 2015-08-21 19:30 +0200
      Re: [PATCH] mm: use only per-device readahead limit Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-21 20:20 +0200
        Re: [PATCH] mm: use only per-device readahead limit Roman Gushchin <klamm@yandex-team.ru> - 2015-08-21 22:30 +0200
          Re: [PATCH] mm: use only per-device readahead limit Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-21 22:50 +0200
            [PATCH v2] mm: use only per-device readahead limit Roman Gushchin <klamm@yandex-team.ru> - 2015-08-24 14:00 +0200
              Re: [PATCH v2] mm: use only per-device readahead limit Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-08-24 14:50 +0200

csiph-web