Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210666

Re: [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes
Date 2015-08-20 20:30 +0200
Message-ID <pZCL8-4sw-25@gated-at.bofh.it> (permalink)
References <pZuaR-wx-3@gated-at.bofh.it> <pZuaS-wx-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 20, 2015 at 11:12:33AM +0200, Markus Pargmann wrote:

> +	} else if (map->use_single_rw) {
> +		/*
> +		 * We need to handle bus writes separate to support val_bytes
> +		 * that are not powers of 2.
> +		 */

This comment is really hard to understand - the condition block we're in
is nothing to do with the number of val_bytes and the comment is just
making a statement, there's no why in there.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes Markus Pargmann <mpa@pengutronix.de> - 2015-08-20 11:20 +0200
  Re: [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes Mark Brown <broonie@kernel.org> - 2015-08-20 20:30 +0200

csiph-web