Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210660
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/4] spi: mediatek: revise coding style |
| Date | 2015-08-20 20:20 +0200 |
| Message-ID | <pZCBr-4hc-3@gated-at.bofh.it> (permalink) |
| References | <pZuaS-wx-33@gated-at.bofh.it> <pZuky-Ig-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Aug 20, 2015 at 05:19:09PM +0800, Leilk Liu wrote: > This patch revises littery coding style according to comments. I can't understand this commit log, sorry - what are the comments that are being addressed? > - reg_val |= (((high_time - 1) & 0xff) << SPI_CFG0_SCK_HIGH_OFFSET); > - reg_val |= (((low_time - 1) & 0xff) << SPI_CFG0_SCK_LOW_OFFSET); > - reg_val |= (((holdtime - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET); > - reg_val |= (((setuptime - 1) & 0xff) << SPI_CFG0_CS_SETUP_OFFSET); > + reg_val |= (((sck_time - 1) & 0xff) << SPI_CFG0_SCK_HIGH_OFFSET); > + reg_val |= (((sck_time - 1) & 0xff) << SPI_CFG0_SCK_LOW_OFFSET); > + reg_val |= (((cs_time - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET); > + reg_val |= (((cs_time - 1) & 0xff) << SPI_CFG0_CS_SETUP_OFFSET); This isn't a coding style change this is (I think) renaming a bunch of variables for some reason.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] Fixup mediatek spi driver Leilk Liu <leilk.liu@mediatek.com> - 2015-08-20 11:20 +0200
[PATCH v2 3/4] spi: mediatek: use BIT() to instead of SPI_CMD_*_OFFSET Leilk Liu <leilk.liu@mediatek.com> - 2015-08-20 11:30 +0200
[PATCH v2 4/4] spi: mediatek: revise coding style Leilk Liu <leilk.liu@mediatek.com> - 2015-08-20 11:30 +0200
Re: [PATCH v2 4/4] spi: mediatek: revise coding style Mark Brown <broonie@kernel.org> - 2015-08-20 20:20 +0200
[PATCH v2 2/4] spi: medaitek: revise quirks compatibility style Leilk Liu <leilk.liu@mediatek.com> - 2015-08-20 11:30 +0200
[PATCH v2 1/4] spi: mediatek: fix spi incorrect endian usage Leilk Liu <leilk.liu@mediatek.com> - 2015-08-20 11:30 +0200
csiph-web