Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

From	Alexander Kuleshov <kuleshovmail@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()
Date	2015-08-20 19:40 +0200
Message-ID	<pZBYJ-3iA-7@gated-at.bofh.it> (permalink)
References	<pYTXI-61Z-7@gated-at.bofh.it> <pZit4-6m-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Jiri,

On 08-19-15, Jiri Kosina wrote:
> On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
> 
> >  
> > -	hid_debug_init();
> > +	if (hid_debug)
> > +		hid_debug_init();
> 
> How is this change related to the rest of the patch?
> 
> It's wrong anyway, because hid_debug is independent of the debugfs HID 
> debugging facility. Please see for example the printk() a few lines above 
> in this very function, which is emited in case hid_debug is enabled.
>

hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir()  and debugfs_create_file() Jiri Kosina <jikos@kernel.org> - 2015-08-19 22:50 +0200
  Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and  debugfs_create_file() Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-20 19:40 +0200

csiph-web