Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi
Date	2015-08-20 19:30 +0200
Message-ID	<pZBP4-37g-7@gated-at.bofh.it> (permalink)
References	<pZBP4-37g-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

> +/ {
> +	compatible = "altr,socfpga-stratix10";
> +	#address-cells = <1>;
> +	#size-cells = <1>;

I would recommend that you make your root #address-cells and #size-cells equal
to 2, as that will simplify matters later if/when you need to add anything
beyond the first 4GB for some particular board.

If everything in the SoC falls within the first 4GB you can have a ranges
property on your /soc node and have only one cell below that.

[...]

> +	intc: intc@ffff8000 {

The unit-address doesn't match the first address in the reg entry.

> +		compatible = "arm,gic-400", "arm,cortex-a15-gic";
> +		#interrupt-cells = <3>;
> +		interrupt-controller;
> +		reg = <0x0 0xffff9000 0x1000>,
> +		      <0x0 0xffffa000 0x2000>,
> +		      <0x0 0xffffc000 0x1000>,
> +		      <0x0 0xffffd000 0x1000>;
> +	};

Shouldn't the virtual CPU interface also be 0x2000 long?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi Mark Rutland <mark.rutland@arm.com> - 2015-08-20 19:30 +0200

csiph-web