Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209701

Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity for HyperV

Show all headers | View raw

On Wed, 19 Aug 2015, Jiang Liu wrote:
> On 2015/8/19 14:45, Rafael J. Wysocki wrote:
> > Well, the regression at hand has just shown that the assertion in the
> > changelog of that commit ("no need for for special treatment for GSI
> > used by ACPI SCI") does not really hold.  So, if the only motivation
> > for it was to get rid of one extra check in mp_unregister_gsi()
> > (mp_register_gsi() still needs to check if it is dealing with the SCI
> > anyway), I'd vote for reverting it.
> Hi Rafael,
> 	The motivation is to treat SCI as normal IOAPIC interrupt so
> we could enforce stricter pin attribute checking. Now it does reveal
> flaws in ACPI BIOS implementations, but we ran into trouble about how to
> handle those flaws:(

The intent of this change is entirely correct, though it seems that
reality of ACPI is just different.

To be on the safe side of things, I agree with Rafael that we should
revert that patch instead of introducing a single platform quirk.

What we can do is to emit a pr_warn() if we detect inconsistency of
the SCI configuration. That way we might be able to gather information
how wide spread this disease is.

Thanks,

	tglx



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Patch v1] x86, ACPI, irq: Fix a regression caused by Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-09 11:00 +0200
  Re: [Patch v1] x86, ACPI, irq: Fix a regression caused by Thomas Gleixner <tglx@linutronix.de> - 2015-08-18 21:40 +0200
    [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 08:00 +0200
      Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV "Rafael J. Wysocki" <rafael@kernel.org> - 2015-08-19 08:10 +0200
        Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 08:30 +0200
          Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV "Rafael J. Wysocki" <rafael@kernel.org> - 2015-08-19 08:50 +0200
            Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 09:00 +0200
              Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Thomas Gleixner <tglx@linutronix.de> - 2015-08-19 10:40 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Thomas Gleixner <tglx@linutronix.de> - 2015-08-19 10:50 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 11:10 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-20 08:20 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Thomas Gleixner <tglx@linutronix.de> - 2015-08-20 11:20 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-20 11:40 +0200
                Re: [Patch v2] x86, ACPI, irq: Add a quirk to override SCI polarity  for HyperV Thomas Gleixner <tglx@linutronix.de> - 2015-08-20 13:20 +0200
                [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-21 09:40 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 10:20 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Aaron Lu <aaron.lu@intel.com> - 2015-08-26 04:50 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Thomas Gleixner <tglx@linutronix.de> - 2015-08-26 10:00 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Thomas Gleixner <tglx@linutronix.de> - 2015-08-26 11:30 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI "Rafael J. Wysocki" <rafael@kernel.org> - 2015-08-26 22:30 +0200
                Re: [Patch v3] ACPI, PCI: Penalize legacy IRQ used by ACPI SCI Thomas Gleixner <tglx@linutronix.de> - 2015-08-27 00:10 +0200

csiph-web