Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1209663

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

From Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices
Date 2015-08-19 08:50 +0200
Message-ID <pZ5m9-6uL-13@gated-at.bofh.it> (permalink)
References <pZ2eB-1XG-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V3] Watchdog: Fix parent of watchdog_devices Pratyush Anand <panand@redhat.com> - 2015-08-19 05:30 +0200
  Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-19 08:50 +0200
  Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Thierry Reding <thierry.reding@gmail.com> - 2015-08-19 12:20 +0200
  Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Maxime Coquelin <maxime.coquelin@st.com> - 2015-08-19 13:00 +0200
  Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Guenter Roeck <linux@roeck-us.net> - 2015-08-19 17:40 +0200
  RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-08-20 10:40 +0200
  RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-08-20 10:40 +0200
  Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-02 12:10 +0200

csiph-web