Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209651

Re: linux-next: Tree for Aug 18 (drivers/media/i2c/tc358743.c)

Show all headers | View raw

On 08/18/2015 05:26 PM, Randy Dunlap wrote:
> On 08/18/15 04:40, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20150817:
>>
> 
> on i386:
> 
> when CONFIG_MEDIA_CONTROLLER is not enabled:
> 
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_probe':
> ../drivers/media/i2c/tc358743.c:1890:29: error: 'struct v4l2_subdev' has no member named 'entity'
>   err = media_entity_init(&sd->entity, 1, &state->pad, 0);
>                              ^
> ../drivers/media/i2c/tc358743.c:1940:26: error: 'struct v4l2_subdev' has no member named 'entity'
>   media_entity_cleanup(&sd->entity);
>                           ^
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_remove':
> ../drivers/media/i2c/tc358743.c:1955:26: error: 'struct v4l2_subdev' has no member named 'entity'
>   media_entity_cleanup(&sd->entity);
>                           ^
> 
> 
> 

tc358743: add missing Kconfig dependency/select

This driver depends on VIDEO_V4L2_SUBDEV_API and needs to select HDMI.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index d669547..521bbf1 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -289,7 +289,8 @@ config VIDEO_SAA711X
 
 config VIDEO_TC358743
 	tristate "Toshiba TC358743 decoder"
-	depends on VIDEO_V4L2 && I2C
+	depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+	select HDMI
 	---help---
 	  Support for the Toshiba TC358743 HDMI to MIPI CSI-2 bridge.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: Tree for Aug 18 Stephen Rothwell <sfr@canb.auug.org.au> - 2015-08-18 13:50 +0200
  Re: linux-next: Tree for Aug 18 (drivers/media/i2c/tc358743.c) Randy Dunlap <rdunlap@infradead.org> - 2015-08-18 17:30 +0200
    Re: linux-next: Tree for Aug 18 (drivers/media/i2c/tc358743.c) Hans Verkuil <hverkuil@xs4all.nl> - 2015-08-19 08:30 +0200
  Re: linux-next: Tree for Aug 18 (xen/apic) Randy Dunlap <rdunlap@infradead.org> - 2015-08-18 19:00 +0200
    Re: [Xen-devel] linux-next: Tree for Aug 18 (xen/apic) Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-08-19 18:20 +0200
    Re: [Xen-devel] linux-next: Tree for Aug 18 (xen/apic) David Vrabel <david.vrabel@citrix.com> - 2015-08-20 12:50 +0200

csiph-web