Groups > linux.kernel > #1208771

Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk
Date	2015-08-17 20:10 +0200
Message-ID	<pYx19-6vH-19@gated-at.bofh.it> (permalink)
References	<pYtTA-1QB-13@gated-at.bofh.it> <pYv8Z-3OC-7@gated-at.bofh.it> <pYv90-3OC-11@gated-at.bofh.it> <pYwHL-5TN-1@gated-at.bofh.it> <pYx18-6vH-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
> 2015-08-17 13:47 GMT-04:00 Dan Carpenter <dan.carpenter@oracle.com>:
> >> -                             printk("[Sendconfigpkt]Get Timed out\n");
> >> +                             pr_debug("[Sendconfigpkt]Get Timed out\n");
> >
> >
> > Possibly pr_err()?
> 
> Yep. My mistake. I'll do the same for Set Timed Out also!
> 
> >> -                     printk("DBG [%s: %d]", __func__, __LINE__);     \
> >> -                     printk(__VA_ARGS__);                            \
> >> +                     pr_debug("DBG [%s: %d]", __func__, __LINE__);   \
> >> +                     pr_debug(__VA_ARGS__);                          \
> >
> > This is a behavior change, I think.  pr_debug() needs to be turned on?
> 
> Yes... I didn't pay attention to that! pr_debug needs -DDEBUG in the makefile.
> Should I use pr_info here? Or just acknowledge the behavior change for
> the moment,
> as the next aim is probably, as you said, to remove all the local
> debug code? (it is
> actually part of the TODO of this driver... So I could just work on that next.)

I would probably just do the rest and leave this part as-is since you're
planning to redo it all anyway.  I guess just do stuff which is obvious
and hopefully more and more stuff will become obvious as you go along.
This is a lazy answer but I don't want to think about this driver very
hard...  :P

Also always try to order your patches from least controversial to most
controversial.  It makes it easier to redo things or sometimes Greg
applies the first part of a patch series.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-17 18:10 +0200
  Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-17 19:50 +0200
    Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-17 20:10 +0200
      Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-17 20:10 +0200

csiph-web