Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1208769

Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

From Heiko Stuebner <heiko@sntech.de>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
Date 2015-08-17 20:10 +0200
Message-ID <pYx18-6vH-13@gated-at.bofh.it> (permalink)
References <pYwRt-654-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

Am Montag, 17. August 2015, 19:38:22 schrieb Michael Niewoehner:
> gpio clock is getting disabled to save power but pclk_cpu is needed for
> act8865 regulator

Please refine the commit message a bit :-) . Something along

pclk_cpu needs to keep running and with the recent gpio clock
handling this is not always the case anymore. So add it to the list
of critical clocks.


and also please add "Linus Walleij <linus.walleij@linaro.org>" to the list of 
recipients. As the gpio clock handling change does go through his tree, the 
matching critical clock handling should also go through him.


Heiko

> 
> Signed-off-by: Michael Niewoehner <linux@mniewoehner.de>
> ---
>  drivers/clk/rockchip/clk-rk3188.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3188.c
> b/drivers/clk/rockchip/clk-rk3188.c index e4f9d47..1c93229 100644
> --- a/drivers/clk/rockchip/clk-rk3188.c
> +++ b/drivers/clk/rockchip/clk-rk3188.c
> @@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]
> __initconst = { "aclk_cpu",
>  	"aclk_peri",
>  	"hclk_peri",
> +	"pclk_cpu",
>  };
> 
>  static void __init rk3188_common_clk_init(struct device_node *np)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Michael Niewoehner <linux@mniewoehner.de> - 2015-08-17 20:00 +0200
  Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2015-08-17 20:10 +0200
    Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Michael Niewoehner <linux@mniewoehner.de> - 2015-08-17 21:00 +0200
      Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2015-08-17 21:40 +0200
        Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2015-08-17 22:00 +0200
        [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Michael Niewoehner <linux@mniewoehner.de> - 2015-08-17 22:00 +0200

csiph-web