Groups > linux.kernel > #1208635

Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM framework

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM framework
Date	2015-08-17 17:00 +0200
Message-ID	<pYu3g-220-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <pY1uh-2ZK-9@gated-at.bofh.it> <pY60X-1am-21@gated-at.bofh.it> <pY8cq-4f1-23@gated-at.bofh.it> <pYskO-8di-5@gated-at.bofh.it> <pYsuu-8oB-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 17/08/15 14:09, Andrew Lunn wrote:
> On Mon, Aug 17, 2015 at 02:01:24PM +0100, Srinivas Kandagatla wrote:
>>
>> +Adding Maxime in the loop
>>
>> On 16/08/15 16:37, Stefan Wahren wrote:
>>>>> Another question which spring to mind is, do we want the eeprom to be
>>>>> in /sys twice, the old and the new way? Backwards compatibility says
>>>>> the old must stay. Do we want a way to suppress the new? Or should we
>>>>> be going as far as refractoring the code into a core library, and two
>>>>> wrapper drivers, old and new?
>>> I think these are questions for the framework maintainers.
>>>
>> One of the reasons for the NVMEM framework is to remove that
>> duplicate code in the every driver.  There was no framework/ABI
>> which was guiding such old eeprom sysfs entry in first place, so I
>> dont see an issue in removing it for good. Correct me if am wrong.
>
> The reason for keeping it is backwards compatibility. Having the
> contents of the EEPROM as a file in /sys via this driver is now a part
> of the Linux ABI. You cannot argue it is not an ABI, just because
> there is no framework. Userspace will be assuming it exists at the
> specified location. So we cannot remove it, for existing uses of the
> driver.
Am Ok as long as someone is happy to maintain it.

--srini
>
> However, for new uses of this driver, it is O.K. to only have the
> NVMEM file.
>
>        Andrew
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2015-08-16 05:10 +0200
  Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Stefan Wahren <stefan.wahren@i2se.com> - 2015-08-16 10:30 +0200
    Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2015-08-16 15:20 +0200
      Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Stefan Wahren <stefan.wahren@i2se.com> - 2015-08-16 17:40 +0200
        Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-17 15:10 +0200
          Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2015-08-17 15:20 +0200
            Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-17 17:00 +0200
              Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2015-08-17 17:40 +0200
                Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-17 17:50 +0200
  Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-17 11:50 +0200

csiph-web