Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208561

Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning

Show all headers | View raw

Huaitong Han <huaitong.han@intel.com> writes:

> rdmsrl_safe does not lead to #GP in native kernel although CPU
> does not support INTEL_PT, but if KVM does not support INTEL_PT,
> the codes cannot understand MSR_IA32_RTIT_CTL, and the warning
> is produced.

"the codes"?

> If KVM does not support INTEL_PT, its guest CPUID also does not.
> So test_cpu_cap is added before RDMSR, and it is more in line with
> the code style.

It does make more sense like this, but please improve this commit
message. And don't forget to include Peter in the loop.

FWIW,

Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] RDMSR before test_cpu_capacity brings about KVM warning Huaitong Han <huaitong.han@intel.com> - 2015-08-14 12:10 +0200
  Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-17 14:10 +0200
    Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning "Han, Huaitong" <huaitong.han@intel.com> - 2015-08-17 15:30 +0200

csiph-web