Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208520

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

Show all headers | View raw

Am Montag, 17. August 2015, 12:34:09 schrieb Ulf Hansson:
> [...]
> 
> >>> -               mmc->max_seg_size = mmc->max_req_size;
> >>> -#endif /* CONFIG_MMC_DW_IDMAC */
> >>> +               if (host->use_dma) {
> >>> +                       mmc->max_segs = host->ring_size;
> >> 
> >> I expect this may cause a compiler error since host->ring_size is only
> >> available in the struct dw_mci *host when CONFIG_MMC_DW_IDMAC is set.
> >> 
> >> I have already pulled in this patch from Jaehoon's pull request.
> >> Perhaps I should only amend the patch and change the host->ring_size
> >> to be always available no matter if CONFIG_MMC_DW_IDMAC is set or not?
> > 
> > Sorry for this. if you can, i think good that CONFIG_MMC_DW_IDMAC is
> > removed at struct dw_mci. Could you amend it?
> > If you want to get patch, i will send patch at now.
> 
> No worries, I amend the patch myself.

thanks and sorry for missing that bit.


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-17 12:20 +0200
  Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled Jaehoon Chung <jh80.chung@samsung.com> - 2015-08-17 12:30 +0200
    Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled Heiko Stuebner <heiko@sntech.de> - 2015-08-17 12:40 +0200
    Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-17 12:40 +0200

csiph-web