Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209533

Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

Show all headers | View raw

lyz,

On Tue, Aug 18, 2015 at 2:40 AM, Yunzhi Li <lyz@rock-chips.com> wrote:
> We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should
> be called before dwc2_get_hwparams() to reset core registers to
> default value. Without this the FIFO setting might be incorrect
> because calculating FIFO size need power-on value of
> GRXFSIZ/GNPTXFSIZ/HPTXFSIZ registers.
>
> This patch could avoid warnning massage like in rk3288 platform:
> [    2.074764] dwc2 ff580000.usb: 256 invalid for
> host_perio_tx_fifo_size. Check HW configuration.
>
> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
>
> ---
>
>  drivers/usb/dwc2/core.c     | 2 +-
>  drivers/usb/dwc2/core.h     | 1 +
>  drivers/usb/dwc2/platform.c | 6 ++++++
>  3 files changed, 8 insertions(+), 1 deletion(-)

This seems reasonable to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() Yunzhi Li <lyz@rock-chips.com> - 2015-08-18 11:50 +0200
  Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() Doug Anderson <dianders@chromium.org> - 2015-08-19 01:10 +0200
  Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() John Youn <John.Youn@synopsys.com> - 2015-08-19 02:30 +0200

csiph-web