Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209328

Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and remove redundant clock

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 18, 2015 at 02:19:54PM +0200, Jonas Gorski wrote:

> The usual philosophy is to have one change per patch, so this might be
> better as three patches. But this is Mark's call. Since the driver
> isn't yet in Linus' tree, it might be a-ok to mix style improvements
> and actual fixes, but as soon as it landed in Linus' tree you need to
> keep them separate, so fixes can be easily backported.

This isn't just about making the fixes easy to backport, it's also about
making the patch reviewable and understandable.  When many changes are
included in one patch it makes it harder to tell what any one part of
the patch is intended to do.  As Jonas has identified several bugs
you'll need to resend anyway, please split the series up.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] spi: mediatek: fix spi incorrect endian usage and remove redundant clock Leilk Liu <leilk.liu@mediatek.com> - 2015-08-18 13:00 +0200
  Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and remove  redundant clock Jonas Gorski <jogo@openwrt.org> - 2015-08-18 14:30 +0200
    Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and  remove redundant clock lei liu <leilk.liu@mediatek.com> - 2015-08-18 15:20 +0200
    Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and remove  redundant clock Mark Brown <broonie@kernel.org> - 2015-08-18 18:10 +0200

csiph-web