Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209184

Re: [RFC -v2 5/8] ext4: Do not fail journal due to block allocator

Show all headers | View raw

On Tue 18-08-15 12:39:03, Michal Hocko wrote:
[...]
> @@ -992,9 +992,8 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb,
>  	block = group * 2;
>  	pnum = block / blocks_per_page;
>  	poff = block % blocks_per_page;
> -	page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS);
> -	if (!page)
> -		return -ENOMEM;
> +	page = find_or_create_page(inode->i_mapping, pnum,
> +				   GFP_NOFS|__GFP_NOFAIL);

Scratch this one. find_or_create_page is allowed to return NULL. The
patch is bogus. I was overly eager to turn all places to not check the
return value.

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 5/8] ext4: Do not fail journal due to block allocator mhocko@kernel.org - 2015-08-05 12:00 +0200
  Re: [RFC 5/8] ext4: Do not fail journal due to block allocator Jan Kara <jack@suse.cz> - 2015-08-05 13:50 +0200
  [RFC -v2 5/8] ext4: Do not fail journal due to block allocator Michal Hocko <mhocko@kernel.org> - 2015-08-18 12:40 +0200
    Re: [RFC -v2 5/8] ext4: Do not fail journal due to block allocator Michal Hocko <mhocko@kernel.org> - 2015-08-18 13:00 +0200

csiph-web