Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209145

Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config

Show all headers | View raw

Hi,

On Mon, Aug 17, 2015 at 09:03:38PM +0200, Robert Jarzmik wrote:
> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> 
> > On 16 August 2015 at 19:22, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> >> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> >>
> >>> On 11 Aug 09:57 PM, Robert Jarzmik wrote:
> >>>> The cases of READID detection are broken on pxa3xx. The reason is that
> >>>> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we
> >>>> always have :
> >>>>  - info->use_dma = 0 (regardless of dma support yet)
> >>>>  - info->chunk_size = 0 (not yet detected)
> >>>>
> >>>> The READID issued by pxa3xx_nand_scan() will therefore end up in
> >>>> handle_data_pio(), and do_bytes will be 0, leading to not reading the
> >>>> nand id, and blocking detection.
> >>>>
> >>>> This doesn't happen if "keep_config" is used, which is probably the most
> >>>> tested case.
> >>>>
> >>>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >>>> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O
> >>>> support")
> >>>
> >>> To be fair, Antoine submitted this a while ago:
> >>>
> >>> http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html
> >>>
> >>> Not sure which one takes precedence in such a case (and yours
> >>> has a proper Fixes tag).
> >> His has precedence. How is it that a fix patch is not yet merge since April ?
> >> Is it because it's part of a still in review serie ?
> 
> Antoine, could you resubmit this single patch with this as trailer please :
> Acked-by: Robert Jarzmik <robert.jarzmik@free>
> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O
> support")

I just resend it.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-11 22:10 +0200
  Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without  keep_config Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-16 23:50 +0200
    Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-17 00:30 +0200
      Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-17 19:40 +0200
        Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-17 21:10 +0200
          Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without  keep_config Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-08-18 11:10 +0200

csiph-web