Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208999

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

Show all headers | View raw

（not sure if previous reply has been sent out)
Hi, Ingo, thanks for your review,
On 08/17/2015 06:11 PM, Ingo Molnar wrote:
>
> * Chen Yu <yu.c.chen@intel.com> wrote:
>
>
> So what your changelog fails to mention:
>
>   - You only add this code to the 64-bit kernel. Are 32-bit kernels not affected?
>
I missed the 32-bit case, I'll adjust them to 32/64-bit common path.
>   - the MSR read is done unconditionally. Is MSR_IA32_THERM_CONTROL available
>     architecturally and readable (and has sensible values) on all 64-bit capable
>     x86 CPUs that run this code path?
>
MSR_IA32_THERM_CONTROL is avaliable on Intel Pentium 4, Xeon, Pentium M
and later processors, so I think not all of the 32/64-bit x86 CPUs have
this regiser. Maybe codes like this would be more reasonable?
save:
ctx->clock_modulation_saved = !rdmsrl_safe(MSR_IA32_THERM_CONTROL,
	&ctxt->clock_modulation);
retore:
if (ctxt->clock_modulation_saved)
	wrmsrl(MSR_IA32_THERM_CONTROL, ctxt->clock_modulation);


Best Regards,
Yu
> Thanks,
>
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend Chen Yu <yu.c.chen@intel.com> - 2015-08-17 10:30 +0200
  Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Ingo Molnar <mingo@kernel.org> - 2015-08-17 12:20 +0200
    Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-17 13:50 +0200
    Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Pavel Machek <pavel@ucw.cz> - 2015-08-17 15:30 +0200
      Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Yu Chen <yu.c.chen@intel.com> - 2015-08-18 04:30 +0200
        Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Pavel Machek <pavel@ucw.cz> - 2015-08-18 10:10 +0200
          Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Yu Chen <yu.c.chen@intel.com> - 2015-08-18 11:00 +0200
    Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for  suspend Yu Chen <yu.c.chen@intel.com> - 2015-08-18 04:00 +0200

csiph-web