Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209006

Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings

Show all headers | View raw

> On Aug 17, 2015, at 09:05, Brad Hubbard <bhubbard@redhat.com> wrote:
> 
>    ceph: remove redundant test of head->safe and silence static analysis warnings
> 
>    Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
> ---
> fs/ceph/mds_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 6aa07af..6e196ee 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)
>                mutex_unlock(&mdsc->mutex);
>                goto out;
>        }
> -       if (req->r_got_safe && !head->safe) {
> +       if (req->r_got_safe) {
>                pr_warn("got unsafe after safe on %llu from mds%d\n",
>                           tid, mds);
>                mutex_unlock(&mdsc->mutex);
> -- 

added to our testing branch,

Thanks
Yan, Zheng--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ceph: remove redundant test of head->safe and silence  static analysis warnings Brad Hubbard <bhubbard@redhat.com> - 2015-08-17 03:10 +0200
  Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings "Yan, Zheng" <zyan@redhat.com> - 2015-08-18 04:40 +0200

csiph-web