Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208979

Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to support memoryless node

Show all headers | View raw

On Mon, 17 Aug 2015, Jiang Liu wrote:

> Function xpc_create_gru_mq_uv() allocates memory with __GFP_THISNODE
> flag set, which may cause permanent memory allocation failure on
> memoryless node. So replace cpu_to_node() with cpu_to_mem() to better
> support memoryless node. For node with memory, cpu_to_mem() is the same
> as cpu_to_node().
> 
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
>  drivers/misc/sgi-xp/xpc_uv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
> index 95c894482fdd..9210981c0d5b 100644
> --- a/drivers/misc/sgi-xp/xpc_uv.c
> +++ b/drivers/misc/sgi-xp/xpc_uv.c
> @@ -238,7 +238,7 @@ xpc_create_gru_mq_uv(unsigned int mq_size, int cpu, char *irq_name,
>  
>  	mq->mmr_blade = uv_cpu_to_blade_id(cpu);
>  
> -	nid = cpu_to_node(cpu);
> +	nid = cpu_to_mem(cpu);
>  	page = alloc_pages_exact_node(nid,
>  				      GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE,
>  				      pg_order);

Why not simply fix build_zonelists_node() so that the __GFP_THISNODE 
zonelists are set up to reference the zones of cpu_to_mem() for memoryless 
nodes?

It seems much better than checking and maintaining every __GFP_THISNODE 
user to determine if they are using a memoryless node or not.  I don't 
feel that this solution is maintainable in the longterm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Patch V3 0/9] Enable memoryless node support for x86 Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
  [Patch V3 6/9] i40evf: Use numa_mem_id() to better support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    RE: [Intel-wired-lan] [Patch V3 6/9] i40evf: Use numa_mem_id() to  better support memoryless node "Patil, Kiran" <kiran.patil@intel.com> - 2015-08-17 21:10 +0200
      Re: [Intel-wired-lan] [Patch V3 6/9] i40evf: Use numa_mem_id() to  better support memoryless node Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-08-18 23:40 +0200
  [Patch V3 9/9] mm, x86: Enable memoryless node support to better support CPU/memory hotplug Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    Re: [Patch V3 9/9] mm, x86: Enable memoryless node support to better  support CPU/memory hotplug Tang Chen <tangchen@cn.fujitsu.com> - 2015-08-18 08:20 +0200
      Re: [Patch V3 9/9] mm, x86: Enable memoryless node support to better  support CPU/memory hotplug Tang Chen <tangchen@cn.fujitsu.com> - 2015-08-18 13:40 +0200
    Re: [Patch V3 9/9] mm, x86: Enable memoryless node support to better  support CPU/memory hotplug Ingo Molnar <mingo@kernel.org> - 2015-08-18 09:40 +0200
  [Patch V3 1/9] x86, NUMA, ACPI: Online node earlier when doing CPU hot-addition Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
  [Patch V3 2/9] kernel/profile.c: Replace cpu_to_mem() with cpu_to_node() Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    Re: [Patch V3 2/9] kernel/profile.c: Replace cpu_to_mem() with  cpu_to_node() David Rientjes <rientjes@google.com> - 2015-08-18 02:40 +0200
      Re: [Patch V3 2/9] kernel/profile.c: Replace cpu_to_mem() with  cpu_to_node() Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 09:20 +0200
  [Patch V3 4/9] openvswitch: Replace cpu_to_node() with cpu_to_mem() to support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    Re: [Patch V3 4/9] openvswitch: Replace cpu_to_node() with  cpu_to_mem() to support memoryless node Pravin Shelar <pshelar@nicira.com> - 2015-08-18 02:20 +0200
  [Patch V3 7/9] x86, numa: Kill useless code to improve code readability Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
  [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem()  to support memoryless node David Rientjes <rientjes@google.com> - 2015-08-18 02:30 +0200
      Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to  support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 10:30 +0200
    Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to  support memoryless node Robin Holt <robinmholt@gmail.com> - 2015-08-19 14:00 +0200
      Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to  support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 14:50 +0200
  [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless node Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
    Re: [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless  node David Rientjes <rientjes@google.com> - 2015-08-18 02:40 +0200
  [Patch V3 8/9] mm: Update _mem_id_[] for every possible CPU when memory configuration changes Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-17 05:20 +0200
  Re: [Patch V3 0/9] Enable memoryless node support for x86 Andrew Morton <akpm@linux-foundation.org> - 2015-08-17 23:40 +0200
  Re: [Patch V3 0/9] Enable memoryless node support for x86 Tang Chen <tangchen@cn.fujitsu.com> - 2015-08-18 12:10 +0200
    Re: [Patch V3 0/9] Enable memoryless node support for x86 Jiang Liu <jiang.liu@linux.intel.com> - 2015-08-19 10:10 +0200

csiph-web