Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1208899

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

From Sebastian Herbszt <herbszt@gmx.de>
Newsgroups linux.kernel
Subject Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()
Date 2015-08-17 23:30 +0200
Message-ID <pYA8G-2u0-23@gated-at.bofh.it> (permalink)
References <pYqsG-5w7-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Johannes Thumshirn wrote:
> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
> continues normally and mp gets kfree()d.
> 
> If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
> error label where lpfc_mbuf_free() is called with mp->virt and mp->phys as
> function arguments. This is the use after free. Following the use after free mp
> gets kfree()d again which is a double free.

A similar patch was posted by Colin Ian King on 2015-07-31 [1].

[1] http://marc.info/?l=linux-scsi&m=143835937206204&w=2

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2() Johannes Thumshirn <jthumshirn@suse.de> - 2015-08-17 13:10 +0200
  Re: [PATCH] lpfc: Fix possible use-after-free and double free in  lpfc_mbx_cmpl_rdp_page_a2() Sebastian Herbszt <herbszt@gmx.de> - 2015-08-17 23:30 +0200
    Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2() Johannes Thumshirn <jthumshirn@suse.de> - 2015-08-18 08:40 +0200
      Re: [PATCH] lpfc: Fix possible use-after-free and double free in  lpfc_mbx_cmpl_rdp_page_a2() Sebastian Herbszt <herbszt@gmx.de> - 2015-08-19 00:30 +0200

csiph-web