Groups > linux.kernel > #1207997

Re: [PATCH 14/20] regmap: Add raw_write/read checks for max_raw_write/read sizes

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 14/20] regmap: Add raw_write/read checks for max_raw_write/read sizes
Date	2015-08-15 04:20 +0200
Message-ID	<pXzeH-3OQ-45@gated-at.bofh.it> (permalink)
References	<pWBix-1oV-9@gated-at.bofh.it> <pWBiy-1oV-25@gated-at.bofh.it> <pWCRj-3tG-1@gated-at.bofh.it> <pWDDI-4EJ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 12, 2015 at 02:47:06PM +0200, Markus Pargmann wrote:
> On Wed, Aug 12, 2015 at 12:57:59PM +0100, Mark Brown wrote:
> > On Wed, Aug 12, 2015 at 12:12:39PM +0200, Markus Pargmann wrote:

> > > Check in regmap_raw_read() and regmap_raw_write() for correct maximum
> > > sizes of the operations. Return -E2BIG if this size is not supported
> > > because it is too big.

> > Why not just split the transaction up like your other changes did?

> My intention was to keep these raw functions as close to the actual
> hardware as possible also reporting proper error values. For
> transactions that are split up you could still use the bulk functions.

That's not what we do otherwise, and not what you yourself have done for
some of the other changes in the series like those around multi write.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 14/20] regmap: Add raw_write/read checks for max_raw_write/read sizes Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
  Re: [PATCH 14/20] regmap: Add raw_write/read checks for  max_raw_write/read sizes Mark Brown <broonie@kernel.org> - 2015-08-12 14:00 +0200
    Re: [PATCH 14/20] regmap: Add raw_write/read checks for  max_raw_write/read sizes Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 14:50 +0200
      Re: [PATCH 14/20] regmap: Add raw_write/read checks for  max_raw_write/read sizes Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200

csiph-web