Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207663

Re: [PATCH 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts

Show all headers | View raw

On Thu, Aug 13, 2015 at 04:18:14PM -0700, Stephen Boyd wrote:
> On 08/13/2015 02:33 PM, Mathieu Olivari wrote:
> >Add one new node to the ipq806x.dtsi file to declare & register the
> >hardware spinlock devices. This mechanism is required to be used by
> >other drivers such as SMEM.
> >
> >Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
> >---
> >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> >index 9f727d8..ea7b959 100644
> >--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> >+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> >@@ -67,6 +67,18 @@
> >  			clock-frequency = <32768>;
> >  			#clock-cells = <0>;
> >  		};
> >+
> >+		sfpb_mutex_block: syscon@01200600 {
> 
> I think you can drop the leading 0 here. Also this should be moved into the
> soc node.
> 
> >+			compatible = "syscon";
> >+			reg = <0x01200600 0x100>;
> >+		};
> >+
> >+		sfpb_mutex: sfpb-mutex {
> >+			compatible = "qcom,sfpb-mutex";
> >+			syscon = <&sfpb_mutex_block 4 4>;
> >+
> >+			#hwlock-cells = <1>;
> >+		};
> 
> And this node should be moved to the root /.
> >  	};
> >  	soc: soc {
Right; I'll repost a patch to address both of these.
> 
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] qcom: Add SMEM MTD parser Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-13 23:40 +0200
  [PATCH 3/3] mtd: add SMEM parser for QCOM platforms Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-13 23:40 +0200
    Re: [PATCH 3/3] mtd: add SMEM parser for QCOM platforms Stephen Boyd <sboyd@codeaurora.org> - 2015-08-14 02:40 +0200
      Re: [PATCH 3/3] mtd: add SMEM parser for QCOM platforms Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-14 21:10 +0200
  [PATCH 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-13 23:40 +0200
    Re: [PATCH 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Stephen Boyd <sboyd@codeaurora.org> - 2015-08-14 02:00 +0200
      Re: [PATCH 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-14 21:00 +0200
  [PATCH 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-13 23:40 +0200
    Re: [PATCH 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Stephen Boyd <sboyd@codeaurora.org> - 2015-08-14 01:20 +0200
      Re: [PATCH 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-14 19:30 +0200

csiph-web