Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1207580
| From | David Drysdale <drysdale@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag |
| Date | 2015-08-14 17:40 +0200 |
| Message-ID | <pXpfk-6aB-15@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pWX9q-7Kj-41@gated-at.bofh.it> <pX4DV-1Gi-7@gated-at.bofh.it> <pXfSF-1cz-1@gated-at.bofh.it> <pXjtg-6nG-15@gated-at.bofh.it> <pXnZT-4sx-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Aug 14, 2015 at 3:17 PM, Andy Lutomirski <luto@amacapital.net> wrote: > On Fri, Aug 14, 2015 at 2:29 AM, David Drysdale <drysdale@google.com> wrote: >> On Fri, Aug 14, 2015 at 6:33 AM, Michael Kerrisk (man-pages) >> <mtk.manpages@gmail.com> wrote: >>> On 13 August 2015 at 19:38, Andy Lutomirski <luto@amacapital.net> wrote: >>>> On Thu, Aug 13, 2015 at 2:32 AM, David Drysdale <drysdale@google.com> wrote: >>>>> Signed-off-by: David Drysdale <drysdale@google.com> >>>> >>>> What's the behavior wrt fcntl(F_GETFL, etc)? >>> >>> I would presume that O_BENEATH is one of the so-called "file creation >>> flags". See this paragraph of the DESCRIPTION: >>> >>> In addition, zero or more file creation flags and file status >>> flags can be bitwise-or'd in flags. The file creation flags are >>> O_CLOEXEC, O_CREAT, O_DIRECTORY, O_EXCL, O_NOCTTY, O_NOFOLLOW, >>> O_TMPFILE, O_TRUNC, and O_TTY_INIT. The file status flags are >>> all of the remaining flags listed below. The distinction between >>> these two groups of flags is that the file status flags can be >>> retrieved and (in some cases) modified; see fcntl(2) for details. >>> >>> David, presuming this is correct (I can't see how O_BENEATH could be a >>> "file *status* flag"), your patch should also add O_BENEATH to the >>> list in that paragraph. >> >> Yeah, O_BENEATH makes sense as a file creation flag; I'll add it >> to that list -- thanks for spotting. > > Should there be a test that you can't clear O_BENEATH with F_SETFL? > > --Andy I'll add a test that fcntl(F_SETFL) silently ignores the file creation flags, including O_BENEATH. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv4 0/3] fs: add O_BENEATH flag to openat(2) David Drysdale <drysdale@google.com> - 2015-08-13 11:40 +0200
[PATCHv4 1/3] fs: add O_BENEATH flag to openat(2) David Drysdale <drysdale@google.com> - 2015-08-13 11:40 +0200
[PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag David Drysdale <drysdale@google.com> - 2015-08-13 11:40 +0200
Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag Andy Lutomirski <luto@amacapital.net> - 2015-08-13 19:40 +0200
Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2015-08-14 07:40 +0200
Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag David Drysdale <drysdale@google.com> - 2015-08-14 11:30 +0200
Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag Andy Lutomirski <luto@amacapital.net> - 2015-08-14 16:20 +0200
Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag David Drysdale <drysdale@google.com> - 2015-08-14 17:40 +0200
[PATCHv4 2/3] selftests: Add test of O_BENEATH & openat(2) David Drysdale <drysdale@google.com> - 2015-08-13 11:40 +0200
csiph-web