Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207599

[PATCH v2 0/4] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only

Show all headers | View raw

The pci-host-generic driver parses the linux,pci-probe-only property,
and assumes that it will have a boolean parameter.

Turns out that the Seattle DTS file has a naked "linux,pci-probe-only"
property, which leads to the driver dereferencing some unsuspecting
memory location. Nothing really bad happens (we end up reading some
other bit of DT, fortunately), but that not a reason to keep it this
way. Turns out that the Pseries code (where this code was lifted from)
may suffer from the same issue.

The first patch introduces a common (and fixed) version of that check
that can be used by drivers and architectures that require it. The two
following patches change the pci-host-generic driver and the powerpc
code to use it.

Finally, the bad property is removed from the Seatle DTS, because it
is simply not necessary (it actually prevents me from using SR-IOV,
which otherwise runs fine without the probe-only thing).

This has been tested on the offending Seattle board.

* From v1:
  - Consolidate the parsing in of_pci.c (Bjorn)

Marc Zyngier (4):
  of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only"
  PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property
  powerpc: PCI: Fix lookup of linux,pci-probe-only property
  arm64: dts: Drop linux,pci-probe-only from the Seattle DTS

 arch/arm64/boot/dts/amd/amd-overdrive.dts |  1 -
 arch/powerpc/platforms/pseries/setup.c    | 14 ++------------
 drivers/of/of_pci.c                       | 30 ++++++++++++++++++++++++++++++
 drivers/pci/host/pci-host-generic.c       |  9 +--------
 include/linux/of_pci.h                    |  3 +++
 5 files changed, 36 insertions(+), 21 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 18:20 +0200
  [PATCH v2 4/4] arm64: dts: Drop linux,pci-probe-only from the Seattle DTS Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 18:20 +0200
  [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 18:20 +0200
    Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of  linux,pci-probe-only property Will Deacon <will.deacon@arm.com> - 2015-08-14 18:50 +0200
    Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of  linux,pci-probe-only property Bjorn Helgaas <bhelgaas@google.com> - 2015-08-14 18:50 +0200
      Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of  linux,pci-probe-only property Will Deacon <will.deacon@arm.com> - 2015-08-14 18:50 +0200
        Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property Alexander Graf <agraf@suse.de> - 2015-08-14 19:00 +0200
        Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of  linux,pci-probe-only property Bjorn Helgaas <bhelgaas@google.com> - 2015-08-14 22:30 +0200
          Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of  linux,pci-probe-only property Will Deacon <will.deacon@arm.com> - 2015-08-17 11:10 +0200
  [PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only" Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 18:20 +0200
    Re: [PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only" Rob Herring <robherring2@gmail.com> - 2015-08-14 23:10 +0200
  [PATCH v2 3/4] powerpc: PCI: Fix lookup of linux,pci-probe-only property Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 18:30 +0200

csiph-web