Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1207568
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 0/3] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only |
| Date | 2015-08-14 16:50 +0200 |
| Message-ID | <pXosV-50q-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The pci-host-generic driver parses the linux,pci-probe-only property, and assumes that it will have a boolean parameter. Turns out that the Seattle DTS file has a naked "linux,pci-probe-only" property, which leads to the driver dereferencing some unsuspecting memory location. Nothing really bad happens (we end up reading some other bit of DT, fortunately), but that not a reason to keep it this way. The first patch fixes the driver not to do silly things, and simply give a warning when this happens. The powerpc code from where this code was lifted is also fixed in a second patch. Finally, the bad property is removed from the Seatle DTS, because it is simply not necessary (it actually prevents me from using SR-IOV, which otherwise runs fine without the probe-only thing). Marc Zyngier (3): PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property powerpc: PCI: Fix lookup of linux,pci-probe-only property arm64: dts: Drop linux,pci-probe-only from the Seattle DTS arch/arm64/boot/dts/amd/amd-overdrive.dts | 1 - arch/powerpc/platforms/pseries/setup.c | 15 ++++++++++----- drivers/pci/host/pci-host-generic.c | 15 ++++++++++----- 3 files changed, 20 insertions(+), 11 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 0/3] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 16:50 +0200 [PATCH 1/3] PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property Marc Zyngier <marc.zyngier@arm.com> - 2015-08-14 16:50 +0200
csiph-web