Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1207549

[PATCH 3/7] selftests: exec: fix for running and installing

From Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Newsgroups linux.kernel
Subject [PATCH 3/7] selftests: exec: fix for running and installing
Date 2015-08-14 15:50 +0200
Message-ID <pXnwS-3Fg-27@gated-at.bofh.it> (permalink)
References <pXnwR-3Fg-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Fix three issues in exec testcase:

Add RUN_TESTS rules in order to running the testcases in the build
directory through "make TARGETS=exec kselftest"

Copy symbol link and non-executable file instead of install it,
otherwise this test will fail after installation.

Exec testcases need a "Makefile" in line 346, otherwise it will
be ENOENT instead of EACCES.

Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
---
 tools/testing/selftests/exec/Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
index 6b76bfd..34966a0 100644
--- a/tools/testing/selftests/exec/Makefile
+++ b/tools/testing/selftests/exec/Makefile
@@ -1,4 +1,4 @@
-CFLAGS = -Wall
+CFLAGS = -Wall -g
 BINARIES = execveat
 DEPS = execveat.symlink execveat.denatured script
 all: $(BINARIES) $(DEPS)
@@ -18,11 +18,19 @@ execveat.denatured: execveat
 	$(CC) $(CFLAGS) -o $@ $^
 
 TEST_PROGS := execveat
-TEST_FILES := $(DEPS)
+TEST_FILES := script
 
 include ../lib.mk
 
-override EMIT_TESTS := echo "mkdir -p subdir; (./execveat && echo \"selftests: execveat [PASS]\") || echo \"selftests: execveat [FAIL]\""
+override RUN_TESTS := mkdir -p subdir; (./execveat && echo "selftests: execveat [PASS]") || echo "selftests: execveat [FAIL]"
+
+override EMIT_TESTS := echo "mkdir -p subdir; touch Makefile; (./execveat && echo \"selftests: execveat [PASS]\") || echo \"selftests: execveat [FAIL]\""
+
+override define INSTALL_RULE
+       mkdir -p $(INSTALL_PATH)
+       install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
+       cp -a execveat.symlink execveat.denatured $(INSTALL_PATH)
+endef
 
 clean:
 	rm -rf $(BINARIES) $(DEPS) subdir.moved execveat.moved xxxxx*
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] Improvement kselftest support for arm and arm64 Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2015-08-14 15:50 +0200
  [PATCH 4/7] selftests: check before install Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2015-08-14 15:50 +0200
  [PATCH 2/7] selftests: add CFLAGS_EXTRA Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2015-08-14 15:50 +0200
  [PATCH 6/7] selftests: only compile userfaultfd for x86 and powperpc Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2015-08-14 15:50 +0200
  [PATCH 3/7] selftests: exec: fix for running and installing Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2015-08-14 15:50 +0200

csiph-web