Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1207489

Re: [PATCH 07/19] staging: most: Remove unnecessary externs

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 07/19] staging: most: Remove unnecessary externs
Date 2015-08-14 13:00 +0200
Message-ID <pXkSm-8h8-9@gated-at.bofh.it> (permalink)
References <pW3gR-21h-3@gated-at.bofh.it> <pW3gS-21h-27@gated-at.bofh.it> <pXiGS-5dY-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote:
> On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> > Using 'extern' is not necessary for function prototypes.
> > 
> We use them to mark dependency inversions (callbacks).
> I thought about comments instead of, but I'm not sure what is worse.

I have never heard of anyone using the extern keyword to mean that
before so I feel like it doesn't work as a "putting extern means the
code documents itself".

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/19] staging: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 16/19] staging: rtl8712: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 02/19] staging: dgnc: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 13/19] staging: rtl8188eu: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 04/19] staging: ft1000: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 18/19] staging: wilc1000: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 07/19] staging: most: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
    Re: [PATCH 07/19] staging: most: Remove unnecessary externs Andrey Shvetsov <andrey.shvetsov.ml@gmail.com> - 2015-08-14 10:40 +0200
      Re: [PATCH 07/19] staging: most: Remove unnecessary externs Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-14 13:00 +0200
  [PATCH 11/19] staging: octeon: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 10/19] staging: nvec: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 03/19] staging: fbtft: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 12/19] staging: olpc_dcon: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 15/19] staging: rtl8192u: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 09/19] staging: netlogic: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
  [PATCH 05/19] staging: iio: Remove unnecessary externs Joe Perches <joe@perches.com> - 2015-08-11 00:00 +0200
    Re: [PATCH 05/19] staging: iio: Remove unnecessary externs Lars-Peter Clausen <lars@metafoo.de> - 2015-08-11 20:50 +0200
      Re: [PATCH 05/19] staging: iio: Remove unnecessary externs Jonathan Cameron <jic23@kernel.org> - 2015-08-15 22:00 +0200
        Re: [PATCH 05/19] staging: iio: Remove unnecessary externs Lars-Peter Clausen <lars@metafoo.de> - 2015-08-15 22:10 +0200
          Re: [PATCH 05/19] staging: iio: Remove unnecessary externs Jonathan Cameron <jic23@kernel.org> - 2015-08-15 22:40 +0200

csiph-web