Groups > linux.kernel > #1207399

GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8))

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8))
Date	2015-08-14 10:30 +0200
Message-ID	<pXixc-52G-1@gated-at.bofh.it> (permalink)
References	<pXixc-52G-3@gated-at.bofh.it> <pXixc-52G-5@gated-at.bofh.it> <pXixc-52G-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+linux-kernel

> +#define DECLARE_EWMA(name, _factor, _weight)> 	> 	> 	> 	> \
> +> 	> struct ewma_##name {> 	> 	> 	> 	> 	> 	> \
> +> 	> 	> unsigned long internal;> 	> 	> 	> 	> 	> \
> +> 	> };> 	> 	> 	> 	> 	> 	> 	> 	> \
> +> 	> static inline void ewma_##name##_init(struct ewma_##name *e)> 	> \
> +> 	> {> 	> 	> 	> 	> 	> 	> 	> 	> \
> +> 	> 	> BUILD_BUG_ON(!__builtin_constant_p(_factor));> 	> 	> \
> +> 	> 	> BUILD_BUG_ON(!__builtin_constant_p(_weight));> 	> 	> \
> +> 	> 	> BUILD_BUG_ON(!is_power_of_2(_factor));> 	> 	> 	> \
> +> 	> 	> BUILD_BUG_ON(!is_power_of_2(_weight));> 	> 	> 	> \
> 

So this seemed fine to me, but for some reason the compiler is saying
the BUILD_BUG_ON(!is_power_of_2(x)) fails, if and only if (!)
CONFIG_GCOV_PROFILE_ALL is enabled, which seems to boil down to the
compiler option -fprofile-arcs.

I'm going to replace this with just the code itself, i.e.

                /* both must be a power of 2 */
                BUILD_BUG_ON(_factor & (_factor - 1));
                BUILD_BUG_ON(_weight & (_weight - 1));

but should I have expected this?

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8)) Johannes Berg <johannes@sipsolutions.net> - 2015-08-14 10:30 +0200
  Re: GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8)) Michal Kubecek <mkubecek@suse.cz> - 2015-08-14 11:10 +0200
    Re: GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8)) Johannes Berg <johannes@sipsolutions.net> - 2015-08-14 11:10 +0200

csiph-web