Groups > linux.kernel > #1207396

Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

From	Andrey Shvetsov <andrey.shvetsov.ml@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging/most: fix return value for DIM_GetChannelState
Date	2015-08-14 10:20 +0200
Message-ID	<pXinw-4Rh-15@gated-at.bofh.it> (permalink)
References	<pXinx-4Rh-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
> 
> Signed-off-by: Tomas Melin <tomas.melin@iki.fi>
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> ---
>  drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c
> index 01b7489..a54cf2c 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.c
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c
> @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch,
>  		struct dim_ch_state_t *state_ptr)
>  {
>  	if (!ch || !state_ptr)
> -		return 0;
> +		return NULL;
>  
>  	state_ptr->ready = ch->state.level < 2;
>  	state_ptr->done_buffers = ch->done_sw_buffers_number;
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging/most: fix return value for DIM_GetChannelState Andrey Shvetsov <andrey.shvetsov.ml@gmail.com> - 2015-08-14 10:20 +0200

csiph-web