Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1207392

Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups linux.kernel
Subject Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking
Date Fri, 14 Aug 2015 10:10:02 +0200
Message-ID <pXidQ-4G1-3@gated-at.bofh.it> (permalink)
References <pX9kd-8uM-15@gated-at.bofh.it>
X-Original-To Stuart Yoder <stuart.yoder@freescale.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=W/e6/VaFek2krYdJdAoEWAdPYzOjH+U5P1+7BrmINzs=; b=SnbukLPn0k3GM7tbYzHhqAtHqIah1BVKgWNW43ZYWkhhbNXRH/d34/QHuHawi5NKJq x8c3UMQBp8MiCy0VCg7hROxVao5GO+qsNEaiTAEUWNZ7AvfeB9ULfh0No8N8fTfjoqoq FH6tjDpfOha07hkmr3MhTuCW02oyb09p3ybJuOWMzJGVwnB3u2nzIBXqsrauXH0KbSLk nuu8pBB7pNcKHGgZ5slEpRVW1hPxfIxUYmAM/UEbdxTsjhpz3vuMVksKHJoEjQzNUpSC ZtBZz+n5l3nfTmYjFUdwMfLeSgM512A6wb+TebJWgRcJzHSqxejtl7GBohsIEO3MvoCc x2dw==
MIME-Version 1.0
X-Received by 10.202.224.87 with SMTP id x84mr37679820oig.18.1439539496261; Fri, 14 Aug 2015 01:04:56 -0700 (PDT)
X-Google-Sender-Auth vHbq6t-D8KTrizCyGhuq4INLyG4
Content-Type text/plain; charset=UTF-8
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 54
Organization linux.* mail to news gateway
X-Original-Cc "David S. Miller" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Scott Wood <scottwood@freescale.com>
X-Original-Date Fri, 14 Aug 2015 10:04:56 +0200
X-Original-Message-ID <CAMuHMdU2NiaPx5t7Aa2DF6OPc2ajW0yVV-vn_QS6JyWTw7rivw@mail.gmail.com>
X-Original-References <1439503319-25453-1-git-send-email-stuart.yoder@freescale.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1207392

Show key headers only | View raw


On Fri, Aug 14, 2015 at 12:01 AM, Stuart Yoder
<stuart.yoder@freescale.com> wrote:
> make the list of Kconfig dependencies for Freescale
> networking more general. Simplify to supported
> architectures: ARM, ARM64, PPC, M68K
>
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ff76d4e..70782d7 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -5,9 +5,7 @@
>  config NET_VENDOR_FREESCALE
>         bool "Freescale devices"
>         default y
> -       depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
> -                  M523x || M527x || M5272 || M528x || M520x || M532x || \
> -                  ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM)
> +       depends on M68K || PPC || ARM || ARM64
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y.

This breaks m68k/allmodconfig:

drivers/net/ethernet/freescale/gianfar.c: In function ‘gfar_parse_group’:
drivers/net/ethernet/freescale/gianfar.c:684: error: ‘NO_IRQ’
undeclared (first use in this function)
drivers/net/ethernet/freescale/gianfar.c:684: error: (Each undeclared
identifier is reported only once
drivers/net/ethernet/freescale/gianfar.c:684: error: for each function
it appears in.)

P.S. Hint: Would have been caught earlier if the NET_VENDOR_* symbol
     had "|| COMPILE_TEST" among its dependencies.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] net/fsl: simplify Kconfig dependency list for fsl networking Stuart Yoder <stuart.yoder@freescale.com> - 2015-08-14 00:40 +0200
  Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-14 10:10 +0200

csiph-web