Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207319

Re: [PATCH 29/31] parisc: handle page-less SG entries

Show all headers | View raw

On Thu, 2015-08-13 at 20:30 -0700, Dan Williams wrote:
> On Thu, Aug 13, 2015 at 7:31 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Wed, Aug 12, 2015 at 09:01:02AM -0700, Linus Torvalds wrote:
> >> I'm assuming that anybody who wants to use the page-less
> >> scatter-gather lists always does so on memory that isn't actually
> >> virtually mapped at all, or only does so on sane architectures that
> >> are cache coherent at a physical level, but I'd like that assumption
> >> *documented* somewhere.
> >
> > It's temporarily mapped by kmap-like helpers.  That code isn't in
> > this series. The most recent version of it is here:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/djbw/nvdimm.git/commit/?h=pfn&id=de8237c99fdb4352be2193f3a7610e902b9bb2f0
> >
> > note that it's not doing the cache flushing it would have to do yet, but
> > it's also only enabled for x86 at the moment.
> 
> For virtually tagged caches I assume we would temporarily map with
> kmap_atomic_pfn_t(), similar to how drm_clflush_pages() implements
> powerpc support.  However with DAX we could end up with multiple
> virtual aliases for a page-less pfn.

At least on some PA architectures, you have to be very careful.
Improperly managed, multiple aliases will cause the system to crash
(actually a machine check in the cache chequerboard). For the most
temperamental systems, we need the cache line flushed and the alias
mapping ejected from the TLB cache before we access the same page at an
inequivalent alias.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 29/31] parisc: handle page-less SG entries Christoph Hellwig <hch@lst.de> - 2015-08-12 09:20 +0200
  Re: [PATCH 29/31] parisc: handle page-less SG entries Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-12 18:10 +0200
    Re: [PATCH 29/31] parisc: handle page-less SG entries Christoph Hellwig <hch@lst.de> - 2015-08-13 16:40 +0200
      Re: [PATCH 29/31] parisc: handle page-less SG entries Dan Williams <dan.j.williams@intel.com> - 2015-08-14 05:40 +0200
        Re: [PATCH 29/31] parisc: handle page-less SG entries James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-08-14 06:00 +0200
          Re: [PATCH 29/31] parisc: handle page-less SG entries David Miller <davem@davemloft.net> - 2015-08-14 06:20 +0200
            Re: [PATCH 29/31] parisc: handle page-less SG entries Dan Williams <dan.j.williams@intel.com> - 2015-08-14 18:20 +0200

csiph-web