Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207286

Re: [PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL

Show all headers | View raw

On 08/08/2015 02:02 AM, Peter Zijlstra wrote:
> On Fri, Aug 07, 2015 at 11:17:56PM -0400, Waiman Long wrote:
>> If _Q_SLOW_VAL has been set, the vCPU state must have been vcpu_hashed.
>> The extra check at the end of __pv_queued_spin_unlock() is unnecessary
>> and so is removed.
> This is half the patch it should be.
>
> Because if the load is not needed, then the store is not either, and
> then there's the comments to update.

Sorry for the late reply.


That is true. Setting state to vcpu_hashed in pv_wait_head() isn't 
really necessary. I kept it there for consistency sake as the state may 
be set to vcpu_hashed in pv_kick_node(). We can certainly take that out.

BTW, could you also review the other patches when you have time? I am 
coming to the LinuxCon/Plumbers next week. Hopefully, I can chat with 
you again.

Cheers,
Longman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL Waiman Long <Waiman.Long@hp.com> - 2015-08-08 05:20 +0200
  Re: [PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with  _Q_SLOW_VAL Peter Zijlstra <peterz@infradead.org> - 2015-08-08 08:10 +0200
    Re: [PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with  _Q_SLOW_VAL Waiman Long <waiman.long@hp.com> - 2015-08-14 04:10 +0200

csiph-web