Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208193

[PATCH 4/7] tools/power turbostat: fix parameter passing for forked command

Show all headers | View raw

From: Len Brown <len.brown@intel.com>

turbostat supports forked command when sampling cpu state. However,
the forked command is not allowed to be executed with options, otherwise
turbostat might regard these options as invalid turbostat options.

For example:

./turbostat stress -c 4 -t 10
./turbostat: unrecognized option '-t'

Reported-by: Chen Yu <yu.c.chen@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5a793be..915eb28 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -3118,7 +3118,7 @@ void cmdline(int argc, char **argv)
 
 	progname = argv[0];
 
-	while ((opt = getopt_long_only(argc, argv, "C:c:Ddhi:JM:m:PpST:v",
+	while ((opt = getopt_long_only(argc, argv, "+C:c:Ddhi:JM:m:PpST:v",
 				long_options, &option_index)) != -1) {
 		switch (opt) {
 		case 'C':
-- 
2.5.0.330.g130be8e

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

intel_idle, turbostat patches queued for upstream Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 7/7] intel_idle: Skylake Client Support Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 4/7] tools/power turbostat: fix parameter passing for forked command Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 3/7] tools/power turbostat: dump CONFIG_TDP Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 6/7] intel_idle: allow idle states to be freeze-mode specific Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 5/7] tools/power turbostat: fix typo on DRAM column in Joules-mode Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200
  [PATCH 2/7] tools/power turbostat: cpu0 is no longer hard-coded, so  update output Len Brown <lenb@kernel.org> - 2015-08-16 05:40 +0200

csiph-web