Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208154

Re: [PATCH] spi: Mediatek: fix endian warnings

Show all headers | View raw

On Saturday 15 August 2015 22:16:03 Arnd Bergmann wrote:
> On Tuesday 11 August 2015 18:43:09 Leilk Liu wrote:
> > @@ -359,9 +359,11 @@ static void mtk_spi_setup_dma_addr(struct spi_master *master,
> >         struct mtk_spi *mdata = spi_master_get_devdata(master);
> >  
> >         if (mdata->tx_sgl)
> > -               writel(cpu_to_le32(xfer->tx_dma), mdata->base + SPI_TX_SRC_REG);
> > +               writel((__force u32)cpu_to_le32(xfer->tx_dma),
> > +                      mdata->base + SPI_TX_SRC_REG);
> >         if (mdata->rx_sgl)
> > -               writel(cpu_to_le32(xfer->rx_dma), mdata->base + SPI_RX_DST_REG);
> > +               writel((__force u32)cpu_to_le32(xfer->rx_dma),
> > +                      mdata->base + SPI_RX_DST_REG);
> >  }
> > 
> 
> This looks wrong: writel takes a CPU-endian argument, so the value returned
> from cpu_to_le32() is not appropriate.
> 
> The warning is correct, and you have to remove the cpu_to_le32() conversion
> in order to get the driver to behave correctly when the kernel is built
> as big-endian.

Nevermind, I now saw the issue has already been raised.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: Mediatek: fix endian warnings Leilk Liu <leilk.liu@mediatek.com> - 2015-08-11 12:50 +0200
  Re: [PATCH] spi: Mediatek: fix endian warnings Jonas Gorski <jogo@openwrt.org> - 2015-08-12 16:50 +0200
    Re: [PATCH] spi: Mediatek: fix endian warnings lei liu <leilk.liu@mediatek.com> - 2015-08-13 04:20 +0200
      Re: [PATCH] spi: Mediatek: fix endian warnings Mark Brown <broonie@kernel.org> - 2015-08-13 11:30 +0200
  Re: [PATCH] spi: Mediatek: fix endian warnings Arnd Bergmann <arnd@arndb.de> - 2015-08-15 22:20 +0200
    Re: [PATCH] spi: Mediatek: fix endian warnings Arnd Bergmann <arnd@arndb.de> - 2015-08-15 22:20 +0200
    Re: [PATCH] spi: Mediatek: fix endian warnings Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-16 16:10 +0200
      Re: [PATCH] spi: Mediatek: fix endian warnings Mark Brown <broonie@kernel.org> - 2015-08-17 05:40 +0200

csiph-web