Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208138

Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context

Show all headers | View raw

On 12/08/15 17:33, Sebastian Andrzej Siewior wrote:
> On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
>> On 08/12/2015 01:00 AM, Xander Huff wrote:
>>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>>> and is thus not able to be acquired from a hardirq handler. This patch gets
>>> rid of the threaded handler and pushes all interrupt handling into the
>>> hardirq context, and uses request_irq().
>>>
>>> To validate that this change has no impact on RT performance, here are
>>> cyclictest values with no processes running:
>>
>> Looks good, thanks.
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> 
> Yes, I'm fine with the rework, too.
Formal Acked-by would be good but I'll take this on the basis of Lars' one
and that the code clearly should work from a read through.

Applied to the togreg branch of iio.git.  Thanks for following through
the various twists of this one. Will initially be pushed out as testing.
Note this has almost certainly (unless Linus announces a delay) missed the
upcoming merge window so will be lined up for the 4.4 one.

Jonathan
> 
> Sebastian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff <xander.huff@ni.com> - 2015-08-12 01:10 +0200
  Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq  context Lars-Peter Clausen <lars@metafoo.de> - 2015-08-12 17:20 +0200
    Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq  context Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-12 18:40 +0200
      Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq  context Jonathan Cameron <jic23@kernel.org> - 2015-08-15 22:00 +0200

csiph-web