Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1208113

[PATCH] drm/nouveau/fifo: fix simple_return.cocci warnings

From kbuild test robot <fengguang.wu@intel.com>
Newsgroups linux.kernel
Subject [PATCH] drm/nouveau/fifo: fix simple_return.cocci warnings
Date 2015-08-15 18:00 +0200
Message-ID <pXM2e-5Yk-19@gated-at.bofh.it> (permalink)
References <pXM2e-5Yk-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c:396:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 g84.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c
@@ -393,12 +393,8 @@ g84_fifo_context_ctor(struct nvkm_object
 	if (ret)
 		return ret;
 
-	ret = nvkm_gpuobj_new(nv_object(base), nv_object(base), 0x0100,
+	return nvkm_gpuobj_new(nv_object(base), nv_object(base), 0x0100,
 			      0x100, NVOBJ_FLAG_ZERO_ALLOC, &base->ramfc);
-	if (ret)
-		return ret;
-
-	return 0;
 }
 
 static struct nvkm_oclass
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] drm/nouveau/fifo: fix simple_return.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2015-08-15 18:00 +0200

csiph-web