Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1208089

Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure

Path csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From Theodore Ts'o <tytso@mit.edu>
Newsgroups linux.kernel
Subject Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure
Date Sat, 15 Aug 2015 16:00:01 +0200
Message-ID <pXKa5-3ff-9@gated-at.bofh.it> (permalink)
References <pU3Em-66q-11@gated-at.bofh.it> <pU3Em-66q-9@gated-at.bofh.it> <pUa38-72o-27@gated-at.bofh.it> <pWAmx-8tE-71@gated-at.bofh.it>
X-Original-To Michal Hocko <mhocko@kernel.org>
Dkim-Signature v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=BQ/KMAfZTXtjCMSMNqFffMeo9kNXEypvR4JE/Her6EM=; b=A9W5NcT0Vmc+NrMpbUx5kEj2zPMf6T3xwu2RvA/PLQxeQRGer1ntSwf1+JHmVlp8k4snMIixnj4VtPXpciXNxZ2ns+EWKkvI+0M1wiOxs0gjVqhMzmTyf+QPswM1010PG5UZ/T1eVAFABbcHi9ai8HrZtnHcjgLThQxC/VMpXoQ=;
Mail-Followup-To Theodore Ts'o <tytso@mit.edu>, Michal Hocko <mhocko@kernel.org>, Greg Thelen <gthelen@google.com>, LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Dave Chinner <david@fromorbit.com>, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP <locally generated>
X-Sa-Exim-Mail-From tytso@thunk.org
X-Sa-Exim-Scanned No (on imap.thunk.org); SAEximRunCond expanded to false
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 18
Organization linux.* mail to news gateway
X-Original-Cc Greg Thelen <gthelen@google.com>, LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Dave Chinner <david@fromorbit.com>, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
X-Original-Date Sat, 15 Aug 2015 09:54:22 -0400
X-Original-Message-ID <20150815135422.GA2976@thunk.org>
X-Original-References <1438768284-30927-1-git-send-email-mhocko@kernel.org> <1438768284-30927-5-git-send-email-mhocko@kernel.org> <xr93twsdwui3.fsf@gthelen.mtv.corp.google.com> <20150812091411.GB14940@dhcp22.suse.cz>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1208089

Show key headers only | View raw


On Wed, Aug 12, 2015 at 11:14:11AM +0200, Michal Hocko wrote:
> > Is this "if (!committed_data) {" check now dead code?
> > 
> > I also see other similar suspected dead sites in the rest of the series.
> 
> You are absolutely right. I have updated the patches.

Have you sent out an updated version of these patches?  Maybe I missed
it, but I don't think I saw them.

Thanks,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure mhocko@kernel.org - 2015-08-05 12:00 +0200
  Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of  frozen_buffer allocation failure Jan Kara <jack@suse.cz> - 2015-08-05 13:50 +0200
  Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure Greg Thelen <gthelen@google.com> - 2015-08-05 18:50 +0200
    Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of  frozen_buffer allocation failure Michal Hocko <mhocko@kernel.org> - 2015-08-12 11:20 +0200
      Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of  frozen_buffer allocation failure Theodore Ts'o <tytso@mit.edu> - 2015-08-15 16:00 +0200
        Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of  frozen_buffer allocation failure Michal Hocko <mhocko@kernel.org> - 2015-08-18 12:40 +0200
  [RFC -v2 4/8] jbd, jbd2: Do not fail journal because of  frozen_buffer allocation failure Michal Hocko <mhocko@kernel.org> - 2015-08-18 12:40 +0200

csiph-web