Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208050

Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive

Show all headers | View raw

Hello!

On Aug 15, 2015, at 4:13 AM, Ioan-Adrian Ratiu wrote:

>>> Without including ptlrpc_internal.h, GCC gives prototype warnings
>>> "pack_generic.c:642:5: warning: no previous prototype for ..."
>> It does?  What version of gcc give you that, I don't see that here.
> Yes, but it's a non-default warning (-Wmissing-prototypes)
> 
> $ gcc --version
> gcc (Gentoo 4.9.3 p1.0, pie-0.6.2) 4.9.3
> 
> When testing the above patch I've used Ubuntu Vivid Vervet's gcc
> (also 4.9 I think, I don't have access to that machine right now).
> 
> To see the warn I'm adding "ccflags-y := -Wmissing-prototypes"
> to a Makefile then "make SUBDIRS=…"

Duh, so essentially it tells you that you have a non-static function
that lacks a previously defined prototype, but because it's
non-static, it's likely used elsewhere and the prototype might get
out of sync with the actual function definition?

I guess it's no big deal to include the ptlrpc_internal.h there
to catch potential problems like that.

Thanks.

Bye,
    Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: ptlrpc: add missing include directive Ioan-Adrian Ratiu <adi@adirat.com> - 2015-08-14 12:00 +0200
  Re: [PATCH] staging: lustre: ptlrpc: add missing include directive Greg KH <gregkh@linuxfoundation.org> - 2015-08-15 04:00 +0200
    Re: [PATCH] staging: lustre: ptlrpc: add missing include directive Ioan-Adrian Ratiu <adi@adirat.com> - 2015-08-15 10:20 +0200
      Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing  include directive "Drokin, Oleg" <oleg.drokin@intel.com> - 2015-08-15 12:20 +0200
      Re: [PATCH] staging: lustre: ptlrpc: add missing include directive Greg KH <gregkh@linuxfoundation.org> - 2015-08-15 18:20 +0200

csiph-web