Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207235

Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values wrong in VM?

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values wrong in VM?
Date 2015-08-14 01:20 +0200
Message-ID <pX9WW-11U-9@gated-at.bofh.it> (permalink)
References (7 earlier) <pX8xQ-7ln-21@gated-at.bofh.it> <pX9Dz-q0-7@gated-at.bofh.it> <pX9DA-q0-9@gated-at.bofh.it> <pX9Dz-q0-5@gated-at.bofh.it> <pX9Ng-QH-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 13, 2015 at 3:59 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Thu, Aug 13, 2015 at 3:56 PM, Kees Cook <keescook@chromium.org> wrote:
>> On Thu, Aug 13, 2015 at 3:54 PM, Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>> On Thu, Aug 13, 2015 at 3:49 PM, Linus Torvalds
>>> <torvalds@linux-foundation.org> wrote:
>>>>
>>>> Does the attached patch make sense and work?
>>>
>>> Btw, I'm not all that happy with it anyway.
>>>
>>> I still think Denys' patch also potentially changed what audit and
>>> strace see for %rax in the pt_regs to -ENOSYS, which I'm not convinced
>>> is a good change.
>>>
>>> But maybe that three-liner patch fixes the immediate problem that
>>> David sees. David?
>>
>> Your patch fixes it for me. The seccomp compat selftests pass again
>> with audit enabled.
>
> Kees, would it be straightforward to rig up the seccomp tests to
> automatically test compat?  The x86 selftests automatically test both
> native and compat, and that might be usable as a model.  I did that
> because it's extremely easy to regress one and not the other.

Yeah, I'll figure out how to get this working sanely. There are some
ugly behaviors on arm64 doing compat that seccomp found too, so I'll
need those targets for more than just x86.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Regression v4.2 ?] 32-bit seccomp-BPF returned errno values wrong in VM? David Drysdale <drysdale@google.com> - 2015-08-13 10:40 +0200
  Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Denys Vlasenko <dvlasenk@redhat.com> - 2015-08-13 17:20 +0200
    Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? David Drysdale <drysdale@google.com> - 2015-08-13 18:30 +0200
      Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Andy Lutomirski <luto@amacapital.net> - 2015-08-13 19:20 +0200
        Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? David Drysdale <drysdale@google.com> - 2015-08-13 19:50 +0200
          Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Kees Cook <keescook@chromium.org> - 2015-08-13 20:50 +0200
            Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Denys Vlasenko <dvlasenk@redhat.com> - 2015-08-13 23:40 +0200
              Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Andy Lutomirski <luto@amacapital.net> - 2015-08-13 23:50 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Kees Cook <keescook@chromium.org> - 2015-08-14 01:00 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Andy Lutomirski <luto@amacapital.net> - 2015-08-14 01:10 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Kees Cook <keescook@chromium.org> - 2015-08-14 01:20 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-14 01:40 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Denys Vlasenko <dvlasenk@redhat.com> - 2015-08-14 14:00 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Andy Lutomirski <luto@amacapital.net> - 2015-08-14 16:30 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? David Drysdale <drysdale@google.com> - 2015-08-14 09:40 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-14 01:00 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Andy Lutomirski <luto@amacapital.net> - 2015-08-14 01:00 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-14 01:30 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-14 01:00 +0200
              Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-14 00:30 +0200
                Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values  wrong in VM? Denys Vlasenko <dvlasenk@redhat.com> - 2015-08-14 13:30 +0200

csiph-web