Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1207147
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 4/8 v2] IB/odp/hmm: prepare for HMM code path. |
| Date | 2015-08-13 22:20 +0200 |
| Message-ID | <pX78J-5uz-1@gated-at.bofh.it> (permalink) |
| References | <pX6ml-4hD-5@gated-at.bofh.it> <pX6ml-4hD-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 13, 2015 at 03:20:49PM -0400, Jérôme Glisse wrote: > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM) > +#else /* CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM */ Yuk, what is wrong with #if !IS_ENABLED(...) ? > -#ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING) > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM) > +#else /* CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM */ Double yuk #if !(IS_ENABLED(..) && IS_ENABLED(..)) ? And the #ifdefs suck, as many as possible should be normal if statements, and one should think carefully if we really need to remove fields from structures.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 4/8 v2] IB/odp/hmm: prepare for HMM code path. Jérôme Glisse <jglisse@redhat.com> - 2015-08-13 21:30 +0200
Re: [RFC PATCH 4/8 v2] IB/odp/hmm: prepare for HMM code path. Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-08-13 22:20 +0200
Re: [RFC PATCH 4/8 v2] IB/odp/hmm: prepare for HMM code path. Jerome Glisse <jglisse@redhat.com> - 2015-08-13 23:20 +0200
csiph-web