Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206930

Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Show all headers | View raw

On 08/12/2015 04:35 PM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@linaro.org> wrote:
>> +       while (ms->num_types != 0) {
>> +               if (ms->major_version == major &&
>> +                   ms->minor_version == minor &&
>> +                   ms->madt_version == madt->header.revision)
>> +                       break;
>> +               ms++;
>> +       }
>> +       if (!ms) {
> 
> Shouldn't this be
> 
>   if (!ms->num_types) {
> 
> instead?
> 

Argh.  Yes, it should.  It will always be false, otherwise.
Will fix for next version.  Thanks for catching that.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] ACPI: Provide better MADT subtable sanity checks Al Stone <al.stone@linaro.org> - 2015-08-06 23:00 +0200
  [PATCH 4/5] ACPI / X86: remove usage of BAD_MADT_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-06 23:10 +0200
  [PATCH 5/5] ACPI: remove definition of BAD_MADT_ENTRY macro Al Stone <al.stone@linaro.org> - 2015-08-06 23:10 +0200
  [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone <al.stone@linaro.org> - 2015-08-06 23:10 +0200
    Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry()  function to eventually replace the macro Timur Tabi <timur@codeaurora.org> - 2015-08-13 00:40 +0200
      Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function  to eventually replace the macro Hanjun Guo <hanjun.guo@linaro.org> - 2015-08-13 11:40 +0200
      Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry()  function to eventually replace the macro Al Stone <al.stone@linaro.org> - 2015-08-13 17:50 +0200
    Re: [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually  replace the macro Hanjun Guo <hanjun.guo@linaro.org> - 2015-08-13 11:30 +0200
  [PATCH 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-06 23:10 +0200
  [PATCH 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-06 23:10 +0200
    Re: [PATCH 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Marc Zyngier <marc.zyngier@arm.com> - 2015-08-07 11:10 +0200
    Re: [PATCH 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Catalin Marinas <catalin.marinas@arm.com> - 2015-08-07 19:00 +0200

csiph-web