Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1206918
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent |
| Date | 2015-08-13 17:30 +0200 |
| Message-ID | <pX2C7-7ft-29@gated-at.bofh.it> (permalink) |
| References | <pX2iJ-6SM-5@gated-at.bofh.it> <pX2iK-6SM-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 13, 2015 at 05:04:05PM +0200, Christoph Hellwig wrote: > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h > index 2ae3424..ab521d5 100644 > --- a/arch/arm/include/asm/dma-mapping.h > +++ b/arch/arm/include/asm/dma-mapping.h > @@ -175,21 +175,6 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) > return dma_addr == DMA_ERROR_CODE; > } > > -/* > - * Dummy noncoherent implementation. We don't provide a dma_cache_sync > - * function so drivers using this API are highlighted with build warnings. > - */ I'd like a similar comment to remain after this patch explaining that we don't support non-coherent allocations and that it'll be highlighted by the lack of dma_cache_sync, otherwise I'm sure we'll start to get patches to add the thing. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
provide more common DMA API functions Christoph Hellwig <hch@lst.de> - 2015-08-13 17:10 +0200
[PATCH 5/5] dma-mapping: consolidate dma_set_mask Christoph Hellwig <hch@lst.de> - 2015-08-13 17:10 +0200
Re: [PATCH 5/5] dma-mapping: consolidate dma_set_mask Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-13 17:30 +0200
Re: [PATCH 5/5] dma-mapping: consolidate dma_set_mask Christoph Hellwig <hch@lst.de> - 2015-08-13 20:00 +0200
[PATCH 1/5] dma-mapping: consolidate dma_{alloc,free}_{attrs,coherent} Christoph Hellwig <hch@lst.de> - 2015-08-13 17:10 +0200
[PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent Christoph Hellwig <hch@lst.de> - 2015-08-13 17:10 +0200
Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-13 17:30 +0200
Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent Christoph Hellwig <hch@lst.de> - 2015-08-13 20:00 +0200
[PATCH 4/5] dma-mapping: consolidate dma_supported Christoph Hellwig <hch@lst.de> - 2015-08-13 17:10 +0200
csiph-web