Groups > linux.kernel > #1206841

Re: [PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag
Date	2015-08-13 16:20 +0200
Message-ID	<pX1wm-5Ix-7@gated-at.bofh.it> (permalink)
References	<pWeci-17Z-9@gated-at.bofh.it> <pWeci-17Z-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 11, 2015 at 11:37:15AM +0200, Jacek Anaszewski wrote:
> This patch adds LED_BRIGHTNESS_BLOCKING flag to the LED core to make it
> capable of discerning between drivers that implement brightness_set op
> in the old manner, i.e. the ones which use work queue internally, and
> drivers that implement brightness_set op in the new manner, i.e. they
> are aware that brightness_set op will be called from a work queue task
> by the LED core.
> In the new approach all drivers that implement brightness_set op should
> also set LED_BRIGHTNESS_BLOCKING flag.

Hi Jacek

Why have the drivers set this flag? The core code can look at the two
ops function pointers and figure it out for itself.

    Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-08-11 11:40 +0200
  Re: [PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag Andrew Lunn <andrew@lunn.ch> - 2015-08-13 16:20 +0200

csiph-web