Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205552

Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

Show all headers | View raw

On 2015/8/12 2:52, Luck, Tony wrote:
>> Well, ok, but do it differently, please: rename
>> cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
>> turns them on and off. Unless Tony has a better suggestion...
>
> I like the boolean argument ... but not the "switch_banks" name. It sounds more
> like we are juggling between banks, rather than setting a switch/flag in a bank.
>
> How does "cmci_storm_set_cmci(bool on)" sound?  Too many "cmci" in one name?

Thanks, I'll use this name.

--
Xie XiuQi

>
> -Tony
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode Xie XiuQi <xiexiuqi@huawei.com> - 2015-08-11 12:20 +0200
  Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to  interrupt mode Borislav Petkov <bp@alien8.de> - 2015-08-11 16:50 +0200
    RE: [PATCH] x86/mce: fix failed to reenable cmci when swiching to  interrupt mode "Luck, Tony" <tony.luck@intel.com> - 2015-08-11 21:00 +0200
      Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to  interrupt mode Xie XiuQi <xiexiuqi@huawei.com> - 2015-08-12 04:10 +0200
    Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to  interrupt mode Xie XiuQi <xiexiuqi@huawei.com> - 2015-08-12 04:10 +0200

csiph-web