Groups > linux.kernel > #1205303

Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return error on failure

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return error on failure
Date	2015-08-11 19:20 +0200
Message-ID	<pWlns-3c7-21@gated-at.bofh.it> (permalink)
References	<pWf8m-2uq-7@gated-at.bofh.it> <pWf8m-2uq-15@gated-at.bofh.it> <pWj2i-86m-27@gated-at.bofh.it> <pWjbY-8hI-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 11, 2015 at 08:29:38PM +0530, Viresh Kumar wrote:
> > This is weird to me, because we are going backwards.  What happens if
> > we goto free_table without adding anything?
> 
> It will WARN() today.

Then the current code is buggy.

> 
> > I suspect it's fine, but if
> > it's a bug then this code still has problems.
> 
> I don't think we have a bug here, we never added anything and so don't
> need to free it.
> 
> > What about if we only increment count when _opp_add_static_v2()
> > succeeds
> 
> That's not what we want.

If the first call to _opp_add_static_v2() fails we call
of_free_opp_table() and you say that triggers a WARN().

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V2 1/6] PM / OPP: Free resources and properly return error on failure Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 12:40 +0200
  Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-11 16:50 +0200
    Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 17:00 +0200
      Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-11 19:20 +0200
        Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-12 08:50 +0200
          Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-12 10:20 +0200
            Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-12 10:30 +0200
              Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-12 11:10 +0200
                Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-12 12:20 +0200
                Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return  error on failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-12 13:00 +0200

csiph-web