Groups > linux.kernel > #1205277

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

From	York Sun <yorksun@freescale.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg
Date	2015-08-11 19:00 +0200
Message-ID	<pWl46-2zU-11@gated-at.bofh.it> (permalink)
References	<pCO8G-1yB-5@gated-at.bofh.it> <pWjOF-Ph-11@gated-at.bofh.it> <pWkro-1QA-7@gated-at.bofh.it> <pWkro-1QA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/11/2015 09:16 AM, Wolfram Sang wrote:
>>>> +	if (of_find_property(np, "little-endian", NULL)) {
>>>
>>> You should check for a "big-endian" property as well, no?
>>
>> I use the little-endian as an option to indicate the nature of litten-endian
>> register. It is default to big-endian if this property doesn't exist. I prefer
>> this way unless you strongly suggest to add both and throw out an error if
>> neither exists.
> 
> I'd think that "little-endian" or "big-endian" force a setting. If none
> is present, we shall take the CPU endianess. Or am I overlooking
> something?

You are right. The current code checks for littel-endian property. If missing,
the CPU endianess is used. Do you prefer to check littlen-endian first, if
missing then big-endian, if both missing then use CPU endianess?

> 
> Oh, and I forgot the biggest issue: I get build errors, because
> __LITTLE_ENDIAN__ should be __LITTLE_ENDIAN. Is this a recent change or
> why did it work for you?
> 

I tested it on 4.0.4 kernel. I see a lot of reference of __LITTLE_ENDIAN__. I
will test the new patch on the latest kernel.

York
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-11 17:40 +0200
  Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-11 18:20 +0200
    Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg York Sun <yorksun@freescale.com> - 2015-08-11 19:00 +0200
      Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-11 22:10 +0200
        Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg York Sun <yorksun@freescale.com> - 2015-08-11 23:10 +0200
          Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-12 03:40 +0200
            Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg York Sun <yorksun@freescale.com> - 2015-08-13 18:40 +0200
              Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-14 20:30 +0200
  Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg York Sun <yorksun@freescale.com> - 2015-08-11 18:20 +0200

csiph-web