Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1205137

Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches
Date 2015-08-11 15:30 +0200
Message-ID <pWhMS-6mR-23@gated-at.bofh.it> (permalink)
References <pUVY6-11L-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 07/08/2015 21:53, Wei Huang wrote:
> These two trivial patches are related to x86 vPMU code. They were
> actually suggested by Andrew Jones while he was reviewing the last
> big vPMU patch set.
> 
> These patches have been compiled and tested on AMD system using
> a 64-bit guest VM with various perf commands (e.g. bench, test, top, 
> stat). No obvious problems were found.
> 
> Thanks,
> -Wei
> 
> Wei Huang (2):
>   KVM: x86/vPMU: Move the definition of kvm_pmu_ops to arch-specific
>     files
>   KVM: x86/vPMU: Fix unnecessary signed extesion for AMD PERFCTRn
> 
>  arch/x86/kvm/pmu.h     | 2 --
>  arch/x86/kvm/pmu_amd.c | 2 --
>  arch/x86/kvm/svm.c     | 1 +
>  arch/x86/kvm/vmx.c     | 1 +
>  4 files changed, 2 insertions(+), 4 deletions(-)
> 

Applied patch 2.  For patch 1 I'm not sure, because I do not really like
1) externs in .c files; 2) globals with no declarations in a .h file.
So I'm leaving it out while I think more about it.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches Wei Huang <wei@redhat.com> - 2015-08-07 22:00 +0200
  [KVM x86 vPMU Patch 1/2] KVM: x86/vPMU: Move the definition of kvm_pmu_ops to arch-specific files Wei Huang <wei@redhat.com> - 2015-08-07 22:00 +0200
    Re: [KVM x86 vPMU Patch 1/2] KVM: x86/vPMU: Move the definition of  kvm_pmu_ops to arch-specific files Andrew Jones <drjones@redhat.com> - 2015-08-11 09:40 +0200
  [KVM x86 vPMU Patch 2/2] KVM: x86/vPMU: Fix unnecessary signed extension for AMD PERFCTRn Wei Huang <wei@redhat.com> - 2015-08-07 22:00 +0200
    Re: [KVM x86 vPMU Patch 2/2] KVM: x86/vPMU: Fix unnecessary signed  extension for AMD PERFCTRn Andrew Jones <drjones@redhat.com> - 2015-08-11 09:40 +0200
  Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches Paolo Bonzini <pbonzini@redhat.com> - 2015-08-11 15:30 +0200
    Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches Wei Huang <wei@redhat.com> - 2015-08-11 17:00 +0200

csiph-web