Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205064
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet |
| Date | 2015-08-11 13:30 +0200 |
| Message-ID | <pWfUJ-3Em-9@gated-at.bofh.it> (permalink) |
| References | <pQfuq-8qO-11@gated-at.bofh.it> <pU6VB-2zD-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 05 August 2015 15:26:52 Pali Rohár wrote:
> On Saturday 25 July 2015 23:46:56 Pali Rohár wrote:
> > - if (psy != bq->notify_psy)
> > - return NOTIFY_OK;
> > + /* Ignore event if it was not send by notify_node/notify_device */
> > + if (bq->notify_node) {
> > + if (psy->dev.parent &&
> > + psy->dev.parent->of_node != bq->notify_node)
> > + return NOTIFY_OK;
>
> There is missing branch for case when psy->dev.parent is NULL. Logical
> error... I will send new version of patch.
>
> Correct logic should be: ignore psy dev which sent event if it is not
> notify dev specified in board/DT config of bq2415x psy dev.
>
Fixed in v2.
--
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet Pali Rohár <pali.rohar@gmail.com> - 2015-08-05 15:30 +0200 Re: [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet Pali Rohár <pali.rohar@gmail.com> - 2015-08-11 13:30 +0200
csiph-web